SOLR-17547: Collect ZK Metrics via Curator #2850
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17547
So there are two ways we can do this.
AdvancedTracerDriver
andCuratorListener
. TheCuratorListener
gives us much better information on what is being done, and we can easily do what needs to be done. All metrics we have currently can be collected given the information passed to theCuratorListener
interface. Unfortunately, theCuratorListener
interface only works for Async actions, such as the curator Async API and Watch events. all other events need to go through theAdvancedTracerDriver
to be collected.The
AdvancedTracerDriver
gives us most of the information we need. There are a few issues:So this is close to good to go, but we need some Curator fixes before we move forward.