Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually make collections PRS enabled in tests #2824

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HoustonPutman
Copy link
Contributor

Fixes issues with #2230, where collections didn't have the PRS flag enabled when the default was enabled.

This does break tests, so it can't be merged without fixing the issues with PRS.

@dsmiley
Copy link
Contributor

dsmiley commented Oct 31, 2024

So the change is to non-test code but it's actually about tests? Would it be more accurate to say that there was a partial/broken attempt to make a cluster-wide default for PRS but this PR completes that?

nit: assuming this system property isn't really advertised/documented, I'd rather it be "solr.cloud.prs" (maybe ".enabled" suffix) and not have the word "default" in it. No sys props needs "default" as a system prop by its very nature is a kind of default.

@HoustonPutman
Copy link
Contributor Author

It is not advertised at all, I believe it is just used for testing. But I think default in the name is fine. Solr.cloud.prs=true, doesn't really tell me what I'm setting to true. Maybe enabled, but that sounds like you are allowing/disallowing something. Maybe we put "test" in the name so that it's clear this is just for testing?

@dsmiley
Copy link
Contributor

dsmiley commented Oct 31, 2024

Even if today we only use it for testing (because only we know of its secret existence), isn't the same mechanism appropriate for a cluster? It needn't be the only way to set it, of course; I could imagine additional layers like cluster props or solr.xml.

solr.cloud.prs.enabled then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants