Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:feat] use binary search optimize random load balance #4935

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

eye-gu
Copy link
Contributor

@eye-gu eye-gu commented Jul 31, 2023

close #4932

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (d8c7b57) 60.99% compared to head (5631bb8) 60.97%.

Files Patch % Lines
...he/shenyu/loadbalancer/spi/RandomLoadBalancer.java 30.76% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4935      +/-   ##
============================================
- Coverage     60.99%   60.97%   -0.03%     
+ Complexity     8622     8621       -1     
============================================
  Files          1258     1258              
  Lines         38426    38424       -2     
  Branches       3679     3680       +1     
============================================
- Hits          23439    23428      -11     
- Misses        12871    12882      +11     
+ Partials       2116     2114       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moremind
Copy link
Member

moremind commented Aug 3, 2023

pending next version~

@eye-gu
Copy link
Contributor Author

eye-gu commented Aug 3, 2023

pending next version~

All right. But I have a question, Why does CI always fail?

@moremind
Copy link
Member

moremind commented Aug 3, 2023

pending next version~

All right. But I have a question, Why does CI always fail?

e2e testing has a bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] <Optimizing RandomLoadBalancer using binary search>
8 participants