Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add pre-commit hook vulture to find dead Python code #1628

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jbampton
Copy link
Member

@jbampton jbampton commented Oct 11, 2024

https://github.com/jendrikseipp/vulture?tab=readme-ov-file#configuration

https://github.com/jendrikseipp/vulture?tab=readme-ov-file#integrations

https://github.com/jendrikseipp/vulture?tab=readme-ov-file#flake8-noqa-comments

https://stackoverflow.com/questions/5033727/how-do-i-get-pyflakes-to-ignore-a-statement

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • No

What changes were proposed in this PR?

Added another check/test to our pre-commit framework.

Cleaned up some Python code.

How was this patch tested?

Ran locally: pre-commit run --all-files

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

pyproject.toml Outdated Show resolved Hide resolved
python/sedona/raster/sedona_raster.py Outdated Show resolved Hide resolved
@jbampton jbampton marked this pull request as ready for review October 12, 2024 00:54
@jbampton jbampton requested a review from jiayuasu as a code owner October 12, 2024 00:54
@jbampton jbampton marked this pull request as draft October 12, 2024 06:37
@jbampton jbampton self-assigned this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant