-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Chore] just test infinite loop case for doris connector #10069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
| if (!isEmpty) { | ||
| ByteBuffer byteBuffer = null; | ||
| while (byteBuffer == null) { | ||
| log.info("stopping buffer data..."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to adjust the log level to debug level ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to adjust the log level to debug level ?
Thank you for your review. This pr is only used to reproduce the problem and does not need to be merged. This log is written for the convenience of observation, as shown in the GitHub CI logs below, the process is stuck in a loop and continuously print this log.
FYI, this problem can only be reproduced under certain conditions. I also spent quite a lot of time creating this test case. If you are interested, you can try running it locally.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok,thx
|
good job |
| Assertions.assertEquals(0, extraCommands.getExitCode(), extraCommands.getStderr()); | ||
| }; | ||
|
|
||
| @Disabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pr is only used to trigger the ci to reproduce this bug. To speed it up, I manually disabled other irrelevant test cases. You can ignore it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could consider adding a short explanation here, similar to this one:
Line 569 in 439b736
| @Disabled("Performance test, not suitable for regular unit test execution") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review ^_^ . This pr is only used to reproduce the problem and does not need to be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have converted it to draft
Purpose of this pull request
Provide a test case for reproduction #10059
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide