feat: enhance StaticNameServerResolver to allow use of gRPC naming sc… #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heme compliant endpoints Signed-off-by: Li Zhanhui <[email protected]>
Signed-off-by: Li Zhanhui <[email protected]>
aaron-ai
approved these changes
Oct 8, 2023
0902horn
reviewed
Oct 9, 2023
| return; | ||
| } | ||
|
|
||
| std::vector<std::string> segments = absl::StrSplit(name_server_list, absl::ByAnyChar(",;")); |
There was a problem hiding this comment.
If name_server_list follows gRPC naming scheme, the first element of segments would keep the prefix - 'ipv4:'. I think naming_scheme_.buildAddress will return a wrong result based on this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…heme compliant endpoints
Which Issue(s) This PR Fixes
Fixes #606
Brief Description
How Did You Test This Change?