Skip to content

RANGER-5322: PolicyRefresher can struck with no download thread if exception thrown in startRefresher #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RANGER-5322: PolicyRefresher can struck with no download thread if exception thrown in startRefresher #667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 28 additions & 10 deletions agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,23 +128,41 @@ public void setLastActivationTimeInMillis(long lastActivationTimeInMillis) {
}

public void startRefresher() {
loadRoles();
loadPolicy();

super.start();
try {
loadRoles();
} catch (Exception e) {
LOG.error("Initial roles load failed for serviceName={}: {}, will retry in {}ms via scheduled refresh", serviceName, e, pollingIntervalMs);
}
try {
loadPolicy();
} catch (Exception e) {
LOG.error("Initial policy load failed for serviceName={}: {}, will retry in {}ms via scheduled refresh", serviceName, e, pollingIntervalMs);
}
initRefresher();
}

private void initRefresher() {
LOG.debug("==> PolicyRefresher(serviceName={}).initRefresher()", serviceName);
try {
super.start();
} catch (IllegalStateException e) {
LOG.error("Failed to start PolicyRefresher thread for serviceName={}", serviceName, e);
throw e;
}
policyDownloadTimer = new Timer("policyDownloadTimer", true);

try {
policyDownloadTimer.schedule(new DownloaderTask(policyDownloadQueue), pollingIntervalMs, pollingIntervalMs);

LOG.debug("Scheduled policyDownloadRefresher to download policies every {} milliseconds", pollingIntervalMs);
} catch (IllegalStateException exception) {
LOG.error("Error scheduling policyDownloadTimer:", exception);
} catch (IllegalArgumentException | IllegalStateException | NullPointerException e) {
LOG.error("Error scheduling policyDownloadTimer:", e);
LOG.error("*** Policies will NOT be downloaded every {} milliseconds ***", pollingIntervalMs);

policyDownloadTimer = null;
if (policyDownloadTimer != null) {
policyDownloadTimer.cancel();
policyDownloadTimer = null;
}
throw e;
}
LOG.debug("<== PolicyRefresher(serviceName={}).initRefresher()", serviceName);
}

public void stopRefresher() {
Expand Down
Loading