-
Notifications
You must be signed in to change notification settings - Fork 369
Ensure we can handle messages with empty payloads that have properties #1432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kellyfj
wants to merge
3
commits into
apache:master
Choose a base branch
from
kellyfj:handle-empty-payload-with-props
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
approved these changes
Nov 28, 2025
Member
time="2025-10-29T05:51:13Z" level=info msg="Created producer" cnx="127.0.0.1:40770 -> 127.0.0.1:6650" producerID=1 producer_name=standalone-0-391 topic="persistent://public/default/my-topic-461702774"
reader_test.go:205:
Error Trace: /pulsar/pulsar-client-go/pulsar/reader_test.go:205
Error: Not equal:
expected: <nil>(<nil>)
actual : []uint8([]byte{})
Test: TestReaderEmptyPayloadNonemptyProps
reader_test.go:205:
Error Trace: /pulsar/pulsar-client-go/pulsar/reader_test.go:205
Error: Not equal:
expected: <nil>(<nil>)
actual : []uint8([]byte{})
Test: TestReaderEmptyPayloadNonemptyProps
reader_test.go:205:
Error Trace: /pulsar/pulsar-client-go/pulsar/reader_test.go:205
Error: Not equal:
expected: <nil>(<nil>)
actual : []uint8([]byte{})
Test: TestReaderEmptyPayloadNonemptyProps
reader_test.go:205:
Error Trace: /pulsar/pulsar-client-go/pulsar/reader_test.go:205
Error: Not equal:
expected: <nil>(<nil>)
actual : []uint8([]byte{})
Test: TestReaderEmptyPayloadNonemptyProps
reader_test.go:205:
Error Trace: /pulsar/pulsar-client-go/pulsar/reader_test.go:205
Error: Not equal:
expected: <nil>(<nil>)
actual : []uint8([]byte{})
Test: TestReaderEmptyPayloadNonemptyProps
reader_test.go:205:
Error Trace: /pulsar/pulsar-client-go/pulsar/reader_test.go:205
Error: Not equal:
expected: <nil>(<nil>)
actual : []uint8([]byte{})
Test: TestReaderEmptyPayloadNonemptyProps
reader_test.go:205:
Error Trace: /pulsar/pulsar-client-go/pulsar/reader_test.go:205
Error: Not equal:
expected: <nil>(<nil>)
actual : []uint8([]byte{})
Test: TestReaderEmptyPayloadNonemptyProps
reader_test.go:205:
Error Trace: /pulsar/pulsar-client-go/pulsar/reader_test.go:205
Error: Not equal:
expected: <nil>(<nil>)
actual : []uint8([]byte{})
Test: TestReaderEmptyPayloadNonemptyProps
reader_test.go:205:
Error Trace: /pulsar/pulsar-client-go/pulsar/reader_test.go:205
Error: Not equal:
expected: <nil>(<nil>)
actual : []uint8([]byte{})
Test: TestReaderEmptyPayloadNonemptyProps
reader_test.go:205:
Error Trace: /pulsar/pulsar-client-go/pulsar/reader_test.go:205
Error: Not equal:
expected: <nil>(<nil>)
actual : []uint8([]byte{})
Test: TestReaderEmptyPayloadNonemptyProps
time="2025-10-29T05:51:13Z" level=info msg="Producer is shutting down. Close the reconnect event loop" producerID=1 producer_name=standalone-0-391 topic="persistent://public/default/my-topic-461702774"
time="2025-10-29T05:51:13Z" level=info msg="Closing producer" producerID=1 producer_name=standalone-0-391 topic="persistent://public/default/my-topic-461702774"
time="2025-10-29T05:51:13Z" level=info msg="Closed producer" producerID=1 producer_name=standalone-0-391 topic="persistent://public/default/my-topic-461702774"
time="2025-10-29T05:51:13Z" level=info msg="Closing consumer=1" consumerID=1 name= subscription=reader-dyiag topic="persistent://public/default/my-topic-461702774"
time="2025-10-29T05:51:13Z" level=info msg="Closed consumer" consumerID=1 name= subscription=reader-dyiag topic="persistent:public/default/my-topic-461702774"
--- FAIL: TestReaderEmptyPayloadNonemptyProps (0.09s)Please handle the exception. |
Member
|
I think this PR was created to reproduce the bug that was fixed in #1435. The corresponding test was already added in that PR, so this one can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Working with folks at StreamNative to use this to validate behavior when a message is received with an empty payload but non-empty properties.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation