Use injected RealmConfig in JdbcMetaStoreManagerFactory #3412
+100
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implicit (auto) bootstrap calls used to share Request Context for potentially many realms. That used to work by coincidence because `RealmConfig`, for example, is a `RequestScoped` bean. With this change each realm will be bootstrapped in its own dedicated Request Context. This change lays down a foundation for future refactoring related to `RealmConfig`.
* Improve code isolation by using `RealmConfig` (like most other code) instead of the lower-level `PolarisConfigurationStore` * This also enabled proper CDI request-scoped injection in concert with apache#3411 * Additionally, this enables further code cleanup in `PolarisConfigurationStore` as discussed in apache#3324 with the goal of using this interface for the backend configuration code, while `RealmConfig` becomes the corresponding frontend interface. * Fix `ServiceProducers.realmConfig()` to make a `RealmConfigImpl` directly from its dependencies (not from `CallContext`) to avoid cycles in CDI.
dimas-b
changed the title
Contributor
Author
|
Draft for now as this PR depends on #3411. Open for comments. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use injected RealmConfig in JdbcMetaStoreManagerFactory
Improve code isolation by using
RealmConfig(like most other code)instead of the lower-level
PolarisConfigurationStoreThis also enabled proper CDI request-scoped injection in concert with Use new Request Context for each realm during implicit bootstrap #3411
Additionally, this enables further code cleanup in
PolarisConfigurationStoreas discussed in Refactor PolarisConfigurationStore to streamline value typing #3324 with the goal of using this interface for the backend
configuration code, while
RealmConfigbecomes the corresponding frontendinterface.
Fix
ServiceProducers.realmConfig()to make aRealmConfigImpldirectly fromits dependencies (not from
CallContext) to avoid cycles in CDI.Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)