Skip to content

Add config to disable S3 trailing checksum validation #3357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rishii-19-works wants to merge 5 commits into from
+18 −0
Closed

Add config to disable S3 trailing checksum validation #3357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c95f5f1
Add per-catalog option to disable S3 trailing checksum validation
rishii-19-works Jan 8, 2026
c04e9bb
Apply AWS storage config to Iceberg S3 properties
rishii-19-works Jan 8, 2026
4ff5d66
Apply Spotless formatting
rishii-19-works Jan 8, 2026
efb56cb
Fix placement of AWS S3 trailing checksum configuration
rishii-19-works Jan 8, 2026
0f99975
Add support to disable S3 trailing checksum via AWS storage config
rishii-19-works Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...s-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ public URI getInternalEndpointUri() {
/** Flag indicating whether path-style bucket access should be forced in S3 clients. */
public abstract @Nullable Boolean getPathStyleAccess();

/** Flag indicating whether S3 trailing checksum validation should be disabled. */
public abstract @Nullable Boolean getDisableS3TrailingChecksum();

/**
* Flag indicating whether STS is available or not. It is modeled in the negative to simplify
* support for unset values ({@code null} being interpreted as {@code false}).
Expand Down
8 changes: 8 additions & 0 deletions ...rvice/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@
import org.apache.polaris.core.storage.PolarisStorageActions;
import org.apache.polaris.core.storage.StorageAccessConfig;
import org.apache.polaris.core.storage.StorageUtil;
import org.apache.polaris.core.storage.aws.AwsStorageConfigurationInfo;
import org.apache.polaris.service.catalog.AccessDelegationMode;
import org.apache.polaris.service.catalog.CatalogPrefixParser;
import org.apache.polaris.service.catalog.SupportsNotifications;
Expand Down Expand Up @@ -862,6 +863,13 @@ ALLOW_FEDERATED_CATALOGS_CREDENTIAL_VENDING, getResolvedCatalogEntity())) {
actions,
refreshCredentialsEndpoint,
resolvedStoragePath);

AwsStorageConfigurationInfo awsConfig =
storageAccessConfig.storageConfigurationInfo().as(AwsStorageConfigurationInfo.class);

if (awsConfig != null && Boolean.TRUE.equals(awsConfig.getDisableS3TrailingChecksum())) {
properties.put("s3.checksum.enabled", "false");
}
Map<String, String> credentialConfig = storageAccessConfig.credentials();
if (delegationModes.contains(VENDED_CREDENTIALS)) {
if (!credentialConfig.isEmpty()) {
Expand Down
7 changes: 7 additions & 0 deletions ...ime/service/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import org.apache.iceberg.CatalogUtil;
import org.apache.iceberg.io.FileIO;
import org.apache.polaris.core.storage.StorageAccessConfig;
import org.apache.polaris.core.storage.aws.AwsStorageConfigurationInfo;

/**
* A default FileIO factory implementation for creating Iceberg {@link FileIO} instances with
Expand Down Expand Up @@ -59,6 +60,12 @@ public FileIO loadFileIO(
properties.putAll(storageAccessConfig.credentials());
properties.putAll(storageAccessConfig.extraProperties());
properties.putAll(storageAccessConfig.internalProperties());
AwsStorageConfigurationInfo awsConfig =
storageAccessConfig.storageConfigurationInfo().as(AwsStorageConfigurationInfo.class);

if (awsConfig != null && Boolean.TRUE.equals(awsConfig.getDisableS3TrailingChecksum())) {
properties.put("s3.checksum.enabled", "false");
}

return loadFileIOInternal(ioImplClassName, properties);
}
Expand Down
Loading