Remove runtime-common and defaults from service deps #3252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main idea is to avoid exposing RDS (added in apache#2650) as a primary dependency of runtime-service since it is conceptually only a dependency on leaf modules (like runtime-server, admin and tests). This is expected to simplify dependency management in downstream projects since runtime-service has a reduced set of transitive dependencies now.
Member
|
Guess it needs some refactoring for JDBC? |
Member
|
I agree with this. You updated OPA, but I guess that other modules should be updated (including the distributions). |
Contributor
Author
|
Yes, sorry about the breakage, I thought it was that simple, but it's not 😅 I'll update the PR once I figure out the build issues. |
dimas-b
added a commit
to dimas-b/polaris
that referenced
this pull request
Dec 13, 2025
`@QuarkusIntegrationTest` uses the regular server build with only non-test dependencies. Therefore, those tests naturally belong into the `server` module. This change is as a prerequisite for apache#3252 to allow the `polaris-runtime-service` module to avoid having Polaris extensions as runtime dependencies. Extensions will be runtime dependencies only in the `polaris-server` module.
6 tasks
dimas-b
added a commit
to dimas-b/polaris
that referenced
this pull request
Dec 15, 2025
`@QuarkusIntegrationTest` uses the regular server build with only non-test dependencies. Therefore, those tests naturally belong into the `server` module. This change is as a prerequisite for apache#3252 to allow the `polaris-runtime-service` module to avoid having Polaris extensions as runtime dependencies. Extensions will be runtime dependencies only in the `polaris-server` module.
6 tasks
dimas-b
added a commit
to dimas-b/polaris
that referenced
this pull request
Dec 16, 2025
`@QuarkusIntegrationTest` uses the regular server build with only non-test dependencies. Therefore, those tests naturally belong into the `server` module. This change is as a prerequisite for apache#3252 to allow the `polaris-runtime-service` module to avoid having Polaris extensions as runtime dependencies. Extensions will be runtime dependencies only in the `polaris-server` module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea is to avoid exposing RDS (added in #2650) as a primary dependency of runtime-service since it is conceptually only a dependency on leaf modules (like runtime-server, admin and tests).
This is expected to simplify dependency management in downstream projects since runtime-service has a reduced set of transitive dependencies now.
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)