-
Notifications
You must be signed in to change notification settings - Fork 340
Add spark sql integration test for Hudi #3194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| // TODO: extract a polaris-rest module as a thin layer for | ||
| // client to depends on. | ||
| implementation(project(":polaris-core")) { isTransitive = false } | ||
| testImplementation("org.apache.hudi:hudi-spark3.5-bundle_${scalaVersion}:1.1.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: we put versions in the file pluginlibs.versions.toml, refer it as line 35 does.
flyrain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks @rahil-c !
| // TODO: extract a polaris-rest module as a thin layer for | ||
| // client to depends on. | ||
| implementation(project(":polaris-core")) { isTransitive = false } | ||
| testImplementation("org.apache.hudi:hudi-spark3.5-bundle_${scalaVersion}:1.1.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the actual spark project, we don't really intend to introduce any table format specific dependency, even for testing. i didn't see any change in the actual spark project, is there a reason that we need this?
| exclude("org.slf4j", "jul-to-slf4j") | ||
| } | ||
|
|
||
| // Add spark-hive for Hudi integration - provides HiveExternalCatalog that Hudi needs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rahil-c could you also update the readme to include the support for hudi?
It would be great if we could also have a notebook in the get-started to help people to onboard for hudi, we could do that in follow up, we should also extend the regress test to include actual end to end test for hudi to avoid any potential break of the feature
Description
SparkDeltaITChecklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)