chore: Add support for controlling the NettyTransport's byteBuf alloc… #1709
+73
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator type. (apache#1707) * chore: Add support for controlling the NettyTransport's byteBuf allocator type. * chore: extract deriveByteBufAllocator method (cherry picked from commit dbc9ed3)
|
This is grey area for me. Whether a change like this be in a patch. If it is really useful then I'd support merging it. That said, I'd prefer if the Flink team test with a 1.2 snapshot and then if they confirm that they get the behaviour that they want then we can merge this. |
|
|
I'm the type of person who puts more faith in opinions if they are backed up by work like in testing Flink with a Pekko snapshot that supports this config before we go to the effort of doing releases. Example build with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ator type. (#1707)
chore: Add support for controlling the NettyTransport's byteBuf allocator type.
chore: extract deriveByteBufAllocator method
(cherry picked from commit dbc9ed3)
related thread: https://lists.apache.org/thread/6lj5lbg18hz4n9zckn0b89p9mv9nz14g