Repository navigation
[common] Remove unused classes - #10815
chenjian2664 wants to merge 7 commits into
Conversation
e5bc1f0 to
33464dd
Compare
GlobalIndexScanner no longer pads shorter indexes with a constant reader. It unions the readers of all index groups for a field instead. Remove the reader and the tests that covered padding.
No code creates or references CastedVector.
No code creates or references SortContext.
BooleanArrayList and MapBuilder have no references. LongTripleArrayList lost its last caller when data evolution row ID assignment was optimized, so remove it together with its test.
BinaryRowDataUtil, ListDelimitedSerializer and ReuseByteArrayOutputStream have no references.
PluginLoader stopped using LocalFileUtils when plugin classes began loading directly from the jar. Remove it together with its test.
SerializablePredicate has no references. ObjectUtils.coalesce was only called from TestCdcEventParser, which now inlines the null check.
33464dd to
5d5b5dd
Compare
chenjian2664
changed the title
|
Thanks for organizing the cleanup into separate commits. I reviewed all 16 changed files and checked repository-wide references, service/configuration strings, generated-code templates and persistence consumers. The 12 removed production types have no current production callers; the remaining changes remove their tests and replace a null-coalescing expression in a CDC test helper. For this production-focused review, the change does not establish a caller-visible correctness fix, a runtime performance/resource benefit, or another end-to-end outcome beyond deleting currently unused code. Closing this cleanup-only PR. A focused change tied to a concrete user/operator problem or measured artifact/runtime benefit would give us a specific outcome to evaluate. |
Purpose
Remove unused classes from paimon-common. Each commit removes one group of related classes and can be reviewed or reverted on its own.
This is the first of a series of small cleanup PRs, one per module.
Tests