HDDS-12100. Move CI dependency installer functions out of _lib.sh #7715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sarvekshayr can you please review? |
sarvekshayr
reviewed
Jan 20, 2025
There was a problem hiding this comment.
Thank you @adoroszlai for the patch. All the functions required for installing various dependencies have been carefully moved to their respective shell scripts. The changes look good to me.
dombizita
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Thanks for working on this @adoroszlai, I have a small question, otherwise it looks good to me!
|
Thanks @dombizita, @sarvekshayr for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
hadoop-ozone/dev-support/checks/_lib.shcontains functions to install dependencies required for running various CI checks (Hugo, SpotBugs, etc.). This file needs to be edited whenever we want to upgrade a dependency (e.g. HDDS-12098 to upgrade Hugo). Since_lib.shis shared between several CI checks, all checks are triggered when the file is changed. However, upgrading Hugo affects only the check using Hugo, i.e. basic (docs). Furthermore, functions to install dependencies may need to be changed when bumping versions. E.g. Hugo artifact name is changed for newer versions.This PR moves the functions that install various dependencies out of
_lib.shto separate shell scripts.selective_ci_checks.shis updated to trigger checks if these new scripts are changed.https://issues.apache.org/jira/browse/HDDS-12100
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/12843513823/job/35815551491#step:7:20
https://github.com/adoroszlai/ozone/actions/runs/12843513823/job/35815551681#step:7:20
https://github.com/adoroszlai/ozone/actions/runs/12843513823/job/35815551764#step:7:20
https://github.com/adoroszlai/ozone/actions/runs/12843513823/job/35815709161#step:6:22
https://github.com/adoroszlai/ozone/actions/runs/12843513823/job/35815709911#step:6:22