Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13995 - CLI - Add start, run once and clear state for processors #9509

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pvillard31
Copy link
Contributor

@pvillard31 pvillard31 commented Nov 11, 2024

Summary

NIFI-13995 - CLI - Add start, run once and clear state for processors

./bin/cli.sh nifi processor-start -procid 0138c512-0193-1000-dbd7-1891f898e909 -p nifi-cli.properties
Name  : ...
ID    : 0138c512-0193-1000-dbd7-1891f898e909
Type  : ...
Bundle: ...
State : RUNNING
./bin/cli.sh nifi processor-clear-state -procid 0138c512-0193-1000-dbd7-1891f898e909 -p nifi-cli.properties
Name  : ...
ID    : 0138c512-0193-1000-dbd7-1891f898e909
Type  : ...
Bundle: ...
State : STOPPED
.bin/cli.sh nifi processor-start -procid 0138c512-0193-1000-dbd7-1891f898e909 --runonce -p nifi-cli.properties
Name  : ...
ID    : 0138c512-0193-1000-dbd7-1891f898e909
Type  : ...
Bundle: ...
State : RUN_ONCE

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these additional commands @pvillard31. I noted one question regarding run-once as an argument versus as a separate command.

@Override
protected void doInitialize(Context context) {
addOption(CommandOption.PROC_ID.createOption());
addOption(CommandOption.RUN_ONCE.createOption());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the risk of having more commands, what do you think about having a separate run-processor command, instead of having RUN_ONCE as an optional argument to start? It seems like that would align more closely with the REST API behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants