NIFI-13989 Reduced the number of constructors in JsonTreeRowRecordReader down to one.

[dan-s1]

Summary

NIFI-13989

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using mvn clean install -P contrib-check
  • JDK 21

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[exceptionfactory]

Thanks for working on this cleanup @dan-s1. The general approach looks good, and I recommend introducing a reusable method in TestJsonTreeRowRecordReader to reduce the duplication.

[dan-s1]

@exceptionfactory Is it okay if I also take care of the various Intellij warnings e.g.

• 'assertTrue()' can be simplified to 'assertInstanceOf()'
• Explicit type argument String, Object can be replaced with <>
• Variable 'mre' is never used
• Can be replaced with 'getFirst()' call
  ?

[exceptionfactory]

@exceptionfactory Is it okay if I also take care of the various Intellij warnings e.g.

* 'assertTrue()' can be simplified to 'assertInstanceOf()'

* Explicit type argument String, Object can be replaced with <>

* Variable 'mre' is never used

* Can be replaced with 'getFirst()' call
  ?

Sure, sounds good!

[exceptionfactory]

It looks like the last commit has a few Checkstyle violations:

Warning:  src/test/java/org/apache/nifi/json/TestJsonTreeRowRecordReader.java:[461,85] (whitespace) WhitespaceAfter: ',' is not followed by whitespace.
Warning:  src/test/java/org/apache/nifi/json/TestJsonTreeRowRecordReader.java:[535,121] (whitespace) WhitespaceAfter: ',' is not followed by whitespace.
Warning:  src/test/java/org/apache/nifi/json/TestJsonTreeRowRecordReader.java:[535,155] (whitespace) WhitespaceAfter: ',' is not followed by whitespace.
Warning:  src/test/java/org/apache/nifi/json/TestJsonTreeRowRecordReader.java:[1327] (sizes) LineLength: Line is longer than 200 characters (found 203).
Warning:  src/test/java/org/apache/nifi/json/TestJsonTreeRowRecordReader.java:[1328,55] (whitespace) WhitespaceAfter: ',' is not followed by whitespace.

[dan-s1]

@exceptionfactory I have corrected the Checkstyle violations. Please review at your earliest convenience. Thanks!

[exceptionfactory]

Thanks for the cleanup @dan-s1! +1 merging