Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13990 - CLI - pg-enable-services will fail if parent PG has disabled CS #9504

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pvillard31
Copy link
Contributor

@pvillard31 pvillard31 commented Nov 8, 2024

Summary

NIFI-13990 - CLI - pg-enable-services will fail if parent PG has disabled CS

Scenario:

  • root process group
    • has a disabled controller service
    • has a process group PG1
  • PG1
    • has multiple controller services

If using pg-enable-services on PG1, it will always fail because it'll check the listed controller services at PG1 level which also includes controller services from parent process groups although the request to enable controller services will not enable controller services in parent process groups.

When checking controller service states, it should filter the list of controller services with the ones defined at the level of the specified process group.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant