Skip to content

MINIFICPP-2589 Refactor ConsumeWindowsEventLog #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: MINIFICPP-2576
Choose a base branch
from

Conversation

fgerlits
Copy link
Contributor

@fgerlits fgerlits commented Aug 12, 2025

https://issues.apache.org/jira/browse/MINIFICPP-2589

  • lots of renaming stuff
  • use magic_enum instead of hand-rolled enum parsing
  • some inlining / pulling out of methods
  • unify the printing of Windows error messages using fmt::format

etc

Depends on #1985.


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@fgerlits fgerlits added the minifi-api-reduced Targets the minifi-api-reduced branch label Aug 12, 2025
* lots of renaming stuff
* use magic_enum instead of hand-rolled enum parsing
* some inlining / pulling out of methods
* unify the printing of Windows error messages using fmt::format
etc
@fgerlits fgerlits force-pushed the MINIFICPP-2589_Refactor-CWEL branch from 2343650 to 914f54b Compare August 18, 2025 14:59
@fgerlits fgerlits removed the minifi-api-reduced Targets the minifi-api-reduced branch label Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant