Skip to content

MINIFICPP-2558 Revamp site to site communication #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lordgamez
Copy link
Contributor

  • Fix communicating with remote output port
  • Add handling of remote port batch size properties
  • Extend port management in config generation in docker integration tests
  • Make input port in remote process groups optional (as using only output ports can also be a valid configuration)
  • Add additional testing
  • Refactor RPG and site to site clients
  • Additional documentation

https://issues.apache.org/jira/browse/MINIFICPP-2565


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@lordgamez lordgamez force-pushed the MINIFICPP-2558 branch 4 times, most recently from 1daf616 to 4433e08 Compare May 19, 2025 14:26
@lordgamez lordgamez marked this pull request as ready for review May 19, 2025 15:49
@szaszm szaszm requested a review from Copilot May 19, 2025 17:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR revamps the Site-to-Site communication along with renaming and updating references to Remote Process Group ports. Key changes include renaming “RemoteProcessorGroupPort” to “RemoteProcessGroupPort” across headers and tests, adding new properties (such as batch size/count/duration and use compression), and updating configuration serializers and documentation to reflect these changes.

Reviewed Changes

Copilot reviewed 54 out of 54 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
libminifi/include/core/reporting/SiteToSiteProvenanceReportingTask.h Updated include and inheritance to use RemoteProcessGroupPort
libminifi/include/core/flow/StructuredConnectionParser.h Renamed helper function to handle both funnels and ports
libminifi/include/core/flow/FlowSchema.h Added definitions for new RPG port properties
libminifi/include/RemoteProcessGroupPort.h Renamed the port class, changed integer types, added timeout and batch property getters/setters, and updated related logic
Test and serializer files Aligned test case names and updated dynamic casts to use RemoteProcessGroupPort
Documentation files Updated SITE_TO_SITE.md and README.md to include Site-to-Site communication details
Comments suppressed due to low confidence (1)

extensions/standard-processors/tests/unit/YamlConfigurationTests.cpp:226

  • [nitpick] Verify that the updated test case tag (dropping the version number) conforms with the project's overall test naming conventions.
TEST_CASE("Test YAML v3 Invalid Type", "[YamlConfiguration]") {

- Fix communicating with remote output port
- Add handling of remote port batch size properties
- Extend port management in config generation in docker integration tests
- Make input port in remote process groups optional (as using only output ports can also be a valid configuration)
- Add additional testing
- Refactor RPG and site to site clients
- Additional documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants