MINIFICPP-2378 Add support for parameters in controller services #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdebreceni
approved these changes
Oct 8, 2024
martinzink
approved these changes
Oct 14, 2024
fgerlits
reviewed
Oct 15, 2024
lordgamez
force-pushed
the
MINIFICPP-2377
branch
from
852793c
to
c71a5d0
Compare
lordgamez
force-pushed
the
MINIFICPP-2378
branch
from
7204b56
to
a9a1ad9
Compare
fgerlits
approved these changes
Oct 16, 2024
szaszm
added a commit
that referenced
this pull request
Oct 21, 2024
lordgamez
force-pushed
the
MINIFICPP-2377
branch
from
c71a5d0
to
35985ad
Compare
lordgamez
force-pushed
the
MINIFICPP-2378
branch
from
a9a1ad9
to
682a2ff
Compare
lordgamez
force-pushed
the
MINIFICPP-2378
branch
from
682a2ff
to
d9bd66a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2378
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.