MINIFICPP-2447 Include the Python processor version in the manifest #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgerlits
force-pushed
the
MINIFICPP-2447_Include_Python_processor_version_in_the_manifest
branch
4 times, most recently
from
11859e5
to
c8465fd
Compare
NiFi python processors which define a ProcessorDetails.version field should show this version number in the manifest. For all other processors, we will continue to use the MiNiFi version.
fgerlits
force-pushed
the
MINIFICPP-2447_Include_Python_processor_version_in_the_manifest
branch
from
c8465fd
to
211fd33
Compare
szaszm
approved these changes
Sep 11, 2024
Comment on lines
+119
to
+121
| void setVersion(const std::string& version) { | ||
| version_ = version; | ||
| } |
There was a problem hiding this comment.
Maybe we could filter empty values to not override the agent version
There was a problem hiding this comment.
Hm, I'm not sure. Is anyone going to set ProcessorDetails.version = ""? If they do, would they expect to see the MiNiFi version in the C2 server GUI?
EDIT: I've changed my mind, because 1: we remove all key-value pairs with empty values when we create the manifest, and 2: our C2 server implementation crashes if it doesn't find a version key in a bundle in the manifest. 521a6c4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2447
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.