Align the shared test base classes with master - #938
Merged
Conversation
FtpWagonTest had assertTrue(true) in a catch block, which asserts nothing; it now checks the exception message. HttpWagonTests is left diverged on purpose: master dropped protected members from that published TCK class for 4.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These test classes drifted from
master, which modernised them in passing: try-with-resourcesinstead of
IOUtil.closein afinally,java.nio.file.Filesinstead ofplexus-utilFileUtils, and aconentstypo. This takes master's versions so the two lines stop divergingin files that every provider migration has to touch.
Two files that also differ are deliberately left alone.
HttpWagonTestsis a published TCKclass and master removed
getConfigurator(),getRepo(),getTmpfiles()andgetPortPropertyValue()from it — that is a 4.0 API drop, not drift, and it should not reach apatch line. In
wagon-webdav-jackrabbit/pom.xmlthe only difference beyond the version is acomment master shortened, where this line's longer wording says more.
One change is not cosmetic:
FtpWagonTesthadassertTrue(true)in a catch block, whichasserts nothing, and master replaced it with
assertNotNull(e.getMessage()). That test nowchecks something it did not check before.
Verified: per-class
<testcase>counts in the surefire XML are unchanged against321d4603across all 30 test classes, with no new errors, failures or skips.
This change was created with AI assistance.