Repository navigation
Link to the filtering resources guide on maven.apache.org - #561
Conversation
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
The PR body says:
Merge after apache/maven-site#1758 is published
As of today, maven-site#1758 is still open, and https://maven.apache.org/guides/mini/guide-filtering-resources.html currently returns HTTP 404.
Merging now would delete ~305 lines of documentation (encoding.md.vm, escape-filtering.md.vm, filter.md) and replace the filtering topic with a dead link. Please hold until the guide is live at the target URL.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
|
|
||
| The following examples show how to use the Resources Plugin in more advanced use cases: | ||
| The [guide to filtering resources](https://maven.apache.org/guides/mini/guide-filtering-resources.html) covers variables, filter files, escaping and encoding. The following examples show how to use the Resources Plugin in more advanced use cases: | ||
|
|
There was a problem hiding this comment.
🔗 Broken link — this URL currently returns HTTP 404. It will only become valid after maven-site#1758 is merged and published.
| <item name="Specifying a character encoding scheme" | ||
| href="/examples/encoding.html"/> | ||
| <item name="Filtering resources (guide)" | ||
| href="https://maven.apache.org/guides/mini/guide-filtering-resources.html"/> |
There was a problem hiding this comment.
💡 Suggestion (not a blocker): the label Filtering resources (guide) replaces three separate items (Specifying a character encoding scheme, Filtering, Escape Filtering). Users searching the nav for encoding will no longer find it under that term. Consider Filtering & encoding (guide) to preserve discoverability.
Removes the filter, escape-filtering and encoding examples, which now live in one guide on maven.apache.org. The binaries and properties-file examples stay.
Merge after apache/maven-site#1758 is published. Part of apache/maven-site#1751