Repository navigation
Add failOnMissingFilterValue parameter to fail on unresolved filter tokens (MRESOURCES-162) - #532
Merged
gnodet merged 1 commit intoSep 30, 2026
Conversation
gnodet
force-pushed
the
fix/mresources-162-fail-on-missing-filter-value
branch
2 times, most recently
from
September 27, 2026 23:47
c855917 to
0993aec
Compare
gnodet
marked this pull request as ready for review
September 28, 2026 18:20
gnodet-bot
reviewed
Sep 28, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
Clean, focused PR. One finding on the @since tag.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
gnodet
requested review from
Bukama,
cstamas,
desruisseaux,
rmannibucau,
slachiewicz and
slawekjaranowski
September 28, 2026 21:46
gnodet-bot
reviewed
Sep 28, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
Re-review after NEW_COMMENTS signal. The previous finding about @since is still unresolved.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
gnodet-bot
approved these changes
Sep 28, 2026
gnodet
requested review from
Bukama,
cstamas,
desruisseaux,
rmannibucau,
slachiewicz and
slawekjaranowski
and removed request for
Bukama,
cstamas,
desruisseaux,
rmannibucau,
slachiewicz and
slawekjaranowski
September 29, 2026 23:05
rmannibucau
approved these changes
Sep 30, 2026
gnodet
added
enhancement
gnodet
force-pushed
the
fix/mresources-162-fail-on-missing-filter-value
branch
from
September 30, 2026 07:17
15bdfa5 to
bea4575
Compare
…lter tokens (MRESOURCES-162) - Add boolean `failOnMissingFilterValue` parameter (default: `false`) to `ResourcesMojo` that causes the build to fail when a filter expression cannot be resolved, instead of silently passing the placeholder through to the output - Wired into `MavenResourcesExecution` (requires maven-filtering 4.0.0-beta-3+) - Configurable via POM or `-Dmaven.resources.failOnMissingFilterValue=true` - Default `false` preserves full backward compatibility - Add IT `MRESOURCES-162-fail`: verifies build fails with unresolved token in error message - Add IT `MRESOURCES-162-pass`: verifies default behavior passes placeholder through Closes apache#400
gnodet
force-pushed
the
fix/mresources-162-fail-on-missing-filter-value
branch
from
September 30, 2026 07:17
bea4575 to
056b9ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #400
Summary
Implements MRESOURCES-162: add a
failOnMissingFilterValueparameter that causes the build to fail when a filter expression in a resource file cannot be resolved, instead of silently leaving the placeholder in the output.Usage
Or via command line:
When enabled, a resource file containing
${missing.property}(wheremissing.propertyis not defined) will fail with:Changes
ResourcesMojo: addfailOnMissingFilterValue@Parameter(defaultfalse, backward compatible), wired intoMavenResourcesExecutionpom.xml: bumpmavenFilteringVersionto4.0.0-beta-2-SNAPSHOT(requires apache/maven-filtering#408)MRESOURCES-162-fail: verifies build fails with the unresolved token in the error messageMRESOURCES-162-pass: verifies default behavior (placeholder passed through as-is)Dependency
This PR depends on apache/maven-filtering#408 which implements the detection in the filter readers. The
mavenFilteringVersionwill be updated to the released version once that PR is merged and released.