Skip to content

[MDEP-964] Allowlist org.glassfish:javax.json #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+12 −5
Open

[MDEP-964] Allowlist org.glassfish:javax.json #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4386f5f
Allowlist org.glassfish:javax.json
elharo Nov 11, 2024
63999bc
integration test
elharo Nov 11, 2024
1037a42
merge
elharo Jul 7, 2025
d54403a
comments
elharo Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/it/projects/analyze/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,18 @@
<artifactId>maven-model</artifactId>
<version>2.0.6</version>
</dependency>
<!-- MDEP-957 slf4j-simple is unused but should not be reported -->
<!-- MDEP-957 slf4j-simple incorrectly appears unused, and should not be reported -->
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-simple</artifactId>
<version>2.0.16</version>
</dependency>
<!-- MDEP-964 javax.json incorrectly appears unused, and should not be reported -->
<dependency>
<groupId>org.glassfish</groupId>
<artifactId>javax.json</artifactId>
<version>1.1.4</version>
</dependency>
</dependencies>

<build>
Expand Down
9 changes: 5 additions & 4 deletions src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public abstract class AbstractAnalyzeMojo extends AbstractMojo {
private boolean ignoreAllNonTestScoped;

/**
* Output the xml for the missing dependencies (used but not declared).
* Output the XML for the missing dependencies (used but not declared).
*
* @since 2.0-alpha-5
*/
Expand Down Expand Up @@ -215,14 +215,15 @@ public abstract class AbstractAnalyzeMojo extends AbstractMojo {
* </p>
*
* <p>Certain dependencies that are known to be used and loaded by reflection
* are always ignored. This includes {@code org.slf4j:slf4j-simple::}.</p>
* are always ignored. This includes {@code org.slf4j:slf4j-simple::}
* and {@code org.glassfish:javax.json::}.</p>
*
* @since 2.10
*/
@Parameter
private String[] ignoredUnusedDeclaredDependencies = new String[0];

private String[] unconditionallyIgnoredDeclaredDependencies = {"org.slf4j:slf4j-simple::"};
private String[] unconditionallyIgnoredDeclaredDependencies = {"org.slf4j:slf4j-simple::,org.glassfish:javax.json::"};

/**
* List of dependencies that are ignored if they are in not test scope but are only used in test classes.
Expand All @@ -241,7 +242,7 @@ public abstract class AbstractAnalyzeMojo extends AbstractMojo {
*
* @since 3.3.0
*/
@Parameter(defaultValue = "org.slf4j:slf4j-simple::")
@Parameter(defaultValue = "org.slf4j:slf4j-simple::,org.glassfish:javax.json::")
private String[] ignoredNonTestScopedDependencies;

/**
Expand Down
Loading