test(runtime): wait for sandbox boundary requests by deadline - #4390
Closed
mikemikimike wants to merge 1 commit into
Closed
test(runtime): wait for sandbox boundary requests by deadline#4390mikemikimike wants to merge 1 commit into
mikemikimike wants to merge 1 commit into
Conversation
Generated-by: Codex
Contributor
Author
|
Withdrawing this PR after verifying that #4383 had already been claimed and assigned before this PR was prepared. No maintainer action is needed on this duplicate contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4383
The sandbox-boundary test helper now waits until a bounded 5-second deadline instead of polling a fixed 100 macrotask ticks. It still polls without changing production behavior, but filesystem setup that takes longer than the old tick budget no longer flakes solely because of scheduler timing.
Verification
npm run build:testnode --test packages/runtime/dist/__tests__/tool-runtime-sandbox-boundary.test.js(15 passed)npm run lintnpm run format:checknpm run typechecknpm run buildgit diff --checknpm testwas run; the full matrix reports Windows-only Rive/remote-access/SQLite failures and workspace timeouts in unrelated suites. The changed sandbox-boundary test passes independently.AI use
Tool(s) and scope: Codex authored the focused test-helper change and validation commands. The commit includes the required
Generated-by: Codextrailer.Checklist
Does this PR entail a change in behavior?