fix(desktop): keep Agent Graph heading visible - #3981
Conversation
Make the Agent Graph heading sticky within the bounded panel so status and controls remain available while operators scroll. Add a Desktop layout regression for the sticky heading, overflow, opaque surface, and collapsed-state contract. Fixes apache#3967 Generated-by: OpenAI Codex
|
Thanks for the review. I addressed the follow-up points in commit
The renderer was rebuilt and the focused Agent Graph E2E passes under Node 22.16.0. No production behavior outside the panel layout was changed. 中文摘要:已使用共享层级 token,补充分隔阴影,并扩展回归测试;renderer 构建和 focused E2E 均通过。 |
|
This is a synthesis of the independent blind review by @Sol-404ARE at exact head What I checked myself:
Findings from Sol's review (file:line anchored, with orchestrator correction): Standards — 2×P2 + 2×P3 (correction: previously stated 2×P3, missing two P2 — apologies)
Production CSS itself is narrowly placed and correctly uses shared sticky/surface/border tokens. No raw color/radius/z-index or other concern was found. Spec — GO (0 P0–P3)
No blocking spec findings were demonstrated; the test limitation (not instantiating full 430px header) is an evidence gap, not a product defect. What I did not judge:
Gate: two P2 + two P3 housekeeping findings remain; no P0/P1 blocks, but the two P2s (synthetic test coverage and AI disclosure) must be fixed (or explicitly waived) before merge. The PR cannot be considered merge-ready until a focused integration test or real-panel coverage is added and the AI-use declaration is completed.
|
Fixes #3967
Summary
Keep the Agent Graph heading visible while a long operator list is scrolled.
--z-stickylayer token and a hairline shadow so the heading stays above content with a clear visual separator.中文摘要
修复长 Agent Graph 列表滚动时头部随内容离开视口的问题。保留现有面板尺寸和折叠行为,让 header 在面板内固定,使用共享层级 token 和细分隔阴影遮挡滚动内容;新增 Desktop E2E 回归测试验证滚动、固定定位、层级、分隔效果和折叠态。
Verification
npm run format:checknpm run lintnpm --workspace @maka/desktop run build:mainnpm --workspace @maka/desktop run build:renderernode --test apps/desktop/dist/main/__tests__/agent-graph-panel.test.js(14/14)e2e/agent-graph-layout.spec.ts(1/1, Node 22.16.0)git diff --check