feat(desktop): add Traditional Chinese locale - #3853
Draft
AcerYue0 wants to merge 6 commits into
Draft
Conversation
AcerYue0
marked this pull request as ready for review
August 26, 2026 03:52
Astro-Han
reviewed
Aug 26, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
I reviewed this head and found blocking i18n issues.
[P2] zh-TW locale mishandled — three places
e2e-fixture.ts:119-123lowercases locale then compares tozh-CN/zh-TW→ both become null.runtime-host-boot.ts:1629-1648passeszh-CNforzh-TWsystems.- Multiple UI fallbacks use
locale!=='en'to pick zh-CN strings, sending Simplified to Traditional users.
Fix: preserve zh-TW throughout and fix comparisons/fallbacks.
简体中文
繁中语言支持被错误归入简中。Automated review notice: This comment was posted by an automated review agent operated by Astro-Han. It is not an independent human review and does not replace one.
M4n5ter
force-pushed
the
feat/zh-tw-locale
branch
from
August 26, 2026 08:51
bf8fe16 to
4b56a8c
Compare
AcerYue0
force-pushed
the
feat/zh-tw-locale
branch
from
August 26, 2026 09:19
4b56a8c to
4b2ce5e
Compare
M4n5ter
force-pushed
the
feat/zh-tw-locale
branch
from
August 26, 2026 09:57
4b2ce5e to
5b8f9db
Compare
AcerYue0
marked this pull request as draft
August 26, 2026 10:07
AcerYue0
marked this pull request as ready for review
August 26, 2026 10:08
added 2 commits
August 27, 2026 10:16
Generated-by: ChatGPT
Generated-by: ChatGPT
Author
|
Addressed the blocking i18n findings in
Local verification now passes: build, lint, format, full typecheck, Core (685), UI (231), Desktop locale-focused suites, and CLI locale suites. Real macOS before/after screenshots are still pending as noted in the PR body. |
Generated-by: ChatGPT
AcerYue0
force-pushed
the
feat/zh-tw-locale
branch
from
August 27, 2026 03:10
5b8f9db to
01d9dec
Compare
added 2 commits
August 27, 2026 11:19
Generated-by: ChatGPT
Generated-by: ChatGPT
AcerYue0
marked this pull request as draft
August 27, 2026 03:28
Generated-by: ChatGPT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add separate
zh-CNandzh-TWresolved locales, including Taiwan-localized UI catalogs and system-locale aliases, while preserving the former persistedzhpreference aszh-CN.Replace the Desktop Settings language segmented control with the existing
@maka/uiSelector, offering Follow system, Simplified Chinese, Traditional Chinese, and English.Verification
npm run build— passednpm run lint— passednpm run format:check— passednpm run typecheck— passednpx knip --workspace apps/desktop— passednpx knip --workspace packages/ui— passednpm --workspace @maka/core test— 685 passednpm --workspace @maka/ui test— 231 passedTraditional Chinese locale screenshots) — added; runs onmacos-15and uploads real Settings screenshots as an artifactReview follow-up
zh-CN/zh-TWE2E fixture flags.zh-TWsurfaces, including Health Center and GitHub Copilot failures.Screenshots
This PR remains a draft until the required real UI screenshots are attached.
AI use
Select exactly one:
Tool(s) and scope: ChatGPT implemented the locale contract, Traditional Chinese catalogs, Settings selector change, review fixes, and related tests.
Checklist
Does this PR entail a change in behavior?