Change instance checks for PerFieldKnnVectorsFormat.FieldsReader to a non-specific method #15187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n unwrap method on KnnVectorsFormat
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
benwtrent
reviewed
Sep 16, 2025
|
|
||
| /** VectorReader that can wrap multiple delegate readers, selected by field. */ | ||
| public static class FieldsReader extends KnnVectorsReader implements HnswGraphProvider { | ||
| private static class FieldsReader extends KnnVectorsReader implements HnswGraphProvider { |
There was a problem hiding this comment.
Since the covering class is lucene.experimental I think this will be OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit nasty that several things in Lucene check for a specific FieldsReader implementation (a nested class, no less). Instead, have a method on
KnnVectorsReaderthat implementations can use to unwrap readers for a field, without referring to specific implementations.