Remove even more boolean success flags

[thecoop]

Most of the remaining ones are in backwards-compatible codecs and the test framework

[thecoop]

Exceptions thrown by this should be handled by the method calling this close() method

[thecoop]

The new code implicitly calls close() on writer after rollback() has been called, but IndexWriter can handle that

[uschindler]

This one is more complicated than the others. Especially the first file is hard. Why was it possible to remove success without any other code change?

[thecoop]

You mean SortingStrategy? sortedFile was being closed in all situations anyway, but this change makes it throw any exceptions regardless. This is ok because this is only used in hunspell.Dictionary, which iterates through the EntrySorter here.

That loop only exits normally once it gets to the end (returns null), all other possible exits of that loop are through exceptions. The exception will bubble up to the caller, where the try block will call EntrySorter.close. If that throws an exception (which it didn't previously), it'll be added as suppressed to the original exception, so the original behaviour is maintained. The only difference is that an exception while closing the file will be added as suppressed, rather than being thrown away completely.

[github-actions]

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!