Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle logs with positive CountDirection, extension preservation and placed in dir #232

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gdziadkiewicz
Copy link
Contributor

@gdziadkiewicz gdziadkiewicz commented Feb 25, 2025

Fix #231

Problem

PreserveLogFileNameExtension was cutting off the directory part that could be present on config's File option. It resulted in unbound rolling of files in the scenario described in the linked issue.

Solution

Fix the issue by making the PreserveLogFileNameExtension code branch handle the directory correctly.

Testing

It can be tested with the configuration provided in linked issue.

@FreeAndNil FreeAndNil added this to the 3.0.5 milestone Feb 25, 2025
…n RollingFileAppender for positive CountDirection, extension preservation and logs in dir
@gdziadkiewicz gdziadkiewicz force-pushed the Fix_#231_Positive_CountDirection_roll branch from 965ba37 to 45f4086 Compare February 28, 2025 06:20
@gdziadkiewicz gdziadkiewicz marked this pull request as ready for review March 10, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RollingFileAppender does not respect the MaxSizeRollBackups with positive CountDirection
2 participants