-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix spelling #3967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spelling #3967
Conversation
|
@garydgregory, would you mind signing your commits, please? Otherwise, your PR cannot be merged. If you need guidance for that, ChatGPT responds well to the following prompt:
Note that you will need to push-force at the end. |
Always with the Byzantine bureaucracy... Using "You can also merge this with the command line." doesn't work either ( |
|
Hi @garydgregory,
It's rather some technical detail. Commits to For example e6392aa is unsigned, but GitHub signed it, when you merged the PR: 43a0e29. If setting up signing is a problem, we can discuss it on Having only signed commits on |
0dfa56f to
91a455a
Compare
Fix spelling.
Important
Base your changes on
2.xbranch if you are targeting Log4j 2; usemainotherwise.Checklist
Before we can review and merge your changes, please go through the checklist below. If you're still working on some items, feel free to submit your pull request as a draft—our CI will help guide you through the remaining steps.
✅ Required checks
License: I confirm that my changes are submitted under the Apache License, Version 2.0.
Commit signatures: All commits are signed and verifiable. (See GitHub Docs on Commit Signature Verification).
Code formatting: The code is formatted according to the project’s style guide.
How to check and fix formatting
./mvnw spotless:check./mvnw spotless:applySee the build instructions for details.
Build & Test: I verified that the project builds and all unit tests pass.
How to build the project
Run:
./mvnw verifySee the build instructions for details.
🧪 Tests (select one)
📝 Changelog (select one)
src/changelog/.2.x.x. (See Changelog Entry File Guide).I did run
mvn clean verify -DskipTests.