KAFKA-19682: Add logs for Kafka Streams task readiness #20693
+28
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (hasPendingTxCommit) { | ||
| // if the task has a pending TX commit, we should just retry the commit but not process any records | ||
| // thus, the task is not processable, even if there is available data in the record queue | ||
| if (log.isDebugEnabled()) { |
There was a problem hiding this comment.
What is the reason for calling isDebugEnabled() only at this specific location and not in the former debug level loggings?
| log.trace("Task {} has no next record to process.", id()); | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
Add else to the if-clause if (!(record instanceof CorruptedRecord)) { and logs for the else-clause?
| partition, recordInfo.queue().size(), maxBufferedSize); | ||
| partitionsToResume.add(partition); | ||
| } | ||
|
|
There was a problem hiding this comment.
Does that make sense to add logs for catch-clauses as well?
| log.debug("Task {} has paused topologies", task.id()); | ||
| return false; | ||
| } else { | ||
| final NamedTopologyMetadata metadata = topologyNameToErrorMetadata.get(topologyName); |
There was a problem hiding this comment.
adding logs here as well?!
|
Thank you, @lucliu1108, for the PR. A bit tricky to choose between using debug and trace ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ticket: https://issues.apache.org/jira/browse/KAFKA-19682
Add more debug/trace logs following the logic of how TaskExecutor
process task.
Reviewers: @mjsax