Skip to content

Conversation

samarth-ksolves
Copy link

@samarth-ksolves samarth-ksolves commented Oct 10, 2025

In this PR, we corrected the argument order in assertEquals within the generator package.

@github-actions github-actions bot added triage PRs from the community tests Test fixes (including flaky tests) generator RPC and Record code generator small Small PRs labels Oct 10, 2025
@AndrewJSchofield AndrewJSchofield added ci-approved and removed triage PRs from the community labels Oct 10, 2025
@AndrewJSchofield AndrewJSchofield self-requested a review October 10, 2025 09:51
Copy link
Member

@AndrewJSchofield AndrewJSchofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. One trivial comment only, but the build is failing. I suggest merging latest changes into this branch.

String.format(" System.out.println(\"hello world\");%n") +
String.format("}%n"));
String.format("}%n"), stringWriter.toString());

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Extra blank lines should be removed please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-approved generator RPC and Record code generator small Small PRs tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants