KAFKA-19724: Global stream thread should not ignore any exceptions #20668
+48
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka Streams does not catch Error types that occur during
GlobalStreamThread
initiation, and therefore it is not possible totrace the error (for example, an
ExceptionInInitializerError
occurswhen RocksDB is not found for a global store). This is because errors
are not caught and logged.
The catch block in
GlobalStreamThread#initialize()
has been ensured tocatch
Throwable
instead ofException
. Additionally, the emptysetUncaughtHandler
set operation that prevented this from takingeffect when users employed setUncaughtExceptionHandler has been removed.
Reviewers: Matthias J. Sax [email protected]