Skip to content

Conversation

celikfatih
Copy link

@celikfatih celikfatih commented Oct 9, 2025

Kafka Streams does not catch Error types that occur during
GlobalStreamThread initiation, and therefore it is not possible to
trace the error (for example, an ExceptionInInitializerError occurs
when RocksDB is not found for a global store). This is because errors
are not caught and logged.

The catch block in GlobalStreamThread#initialize() has been ensured to
catch Throwable instead of Exception. Additionally, the empty
setUncaughtHandler set operation that prevented this from taking
effect when users employed setUncaughtExceptionHandler has been removed.

Reviewers: Matthias J. Sax [email protected]

@github-actions github-actions bot added triage PRs from the community streams small Small PRs labels Oct 9, 2025
@celikfatih celikfatih changed the title KAFKA-19724 KAFKA-19724 Global stream thread ignores all exceptions Oct 9, 2025
@mjsax mjsax added ci-approved and removed triage PRs from the community labels Oct 15, 2025
@mjsax mjsax changed the title KAFKA-19724 Global stream thread ignores all exceptions KAFKA-19724: Global stream thread should not ignore any exceptions Oct 15, 2025
Copy link
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Overall LGTM. One nit about naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants