MINOR: leverage preProcessParsedConfig within AbstractConfig #19259
+25
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a kind of big fix, so please add a test |
3 tasks
Done. Please take a look. |
m1a2st
reviewed
Mar 21, 2025
| props.put("foo.bar", "abc"); | ||
| props.put("setting", "def"); | ||
| TestConfig config = new TestConfig(props); | ||
| assertEquals("success", config.get("preprocess")); |
There was a problem hiding this comment.
Could you also check foo.bar and setting are not in the map?
There was a problem hiding this comment.
If foo.bar and setting is not defined in CONDEF, it will be removed so I deleted these entry.
Thanks for your review and suggestion !
chia7712
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In past, we have
AbstractConfig#preProcessParsedConfigbut did not use its return valueThis PR fix such issue.
Reviewers: Ken Huang [email protected], Chia-Ping Tsai [email protected]