KAFKA-18796: Added more information to error message when assertion fails for acquisition lock timeout #19247
+51
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ails in SharePartitionTest
github-actions
bot
added
triage
AndrewJSchofield
requested changes
Mar 20, 2025
| @@ -6648,6 +6648,15 @@ public void testAcquireWhenBatchesRemovedForFetchOffsetForSameCachedBatch() { | |||
| }); | |||
| }); | |||
| } | |||
|
|
|||
| private String assertionFailedMessage(SharePartition sharePartition) { | |||
There was a problem hiding this comment.
If I understand the usage of this correctly, the hard-coded 5L here should be a parameter to this method.
There was a problem hiding this comment.
I have made the required change. Requesting a re review, thanks !
… SharePartitionTest
AndrewJSchofield
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds extra information in assertion failed messages for tests in SharePartitionTest revolving around acquisition lock timeouts functionality.