Skip to content

Conversation

@AzhanL
Copy link

@AzhanL AzhanL commented Dec 7, 2025

What is the purpose of the pull request

No existing GitHub issue.

Fixes icons not displaying on the landing page due to CSP loading issue.

Current:
image

Fixed Version:
image

Brief change log

Verify this pull request

This pull request is a trivial rework / code cleanup without any test coverage. Can be verified by visiting a deployed version here: https://azhanl.github.io/incubator-xtable/

@the-other-tim-brown
Copy link
Contributor

@AzhanL thanks for pointing this out! My preference is to avoid copying the javascript. I tried to fix this with a different solution but this is far from my expertise. Let me know what you think #764

@AzhanL
Copy link
Author

AzhanL commented Dec 8, 2025

@the-other-tim-brown I reviewed #764, that solution would unfortunately not work due to the CSP in place (left details on that PR). We would need to either add the CSS/JS into the repo or update the CSP policy to allow a CDN. Don't know if updating the policy is doable.

Importing the JS allows loading multiple fonts later without importing them into the repository.

Updating the CSP policy would be the ideal solution, though. I'll check around to see where I can ask for that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants