-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scripts to (semi)automate release steps #116
base: main
Are you sure you want to change the base?
Conversation
This is a great start! I'll check out the branch locally, see if there are any tweaks to make, and maybe try to push up changes to make the verify command interactive. How does that sound? |
Sounds good! Sorry for my lack of reply before. As said, feel free to build on this or deviate from it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tiny questions, but feel free to merge! Thanks, @Treora.
scripts/verify-rc.sh
Outdated
@@ -0,0 +1,52 @@ | |||
set -e | |||
|
|||
#VERSION=0.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove these comments.
scripts/verify-rc.sh
Outdated
# Expects Apache RAT 0.13 jar to be present in home directory | ||
# wget https://dlcdn.apache.org/creadur/apache-rat-0.13/apache-rat-0.13-bin.zip | ||
# unzip apache-rat-0.13-bin.zip | ||
java -jar ~/apache-rat-0.13.jar -E .ratignore -d . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should just download rat here?
I added a commit that downloads RAT, removes comments, removes the sleep pauses too. But I get an error when running this, which looks unrelated to the current change:
Could you perhaps check if it works for you, @tilgovi (or anyone)? |
@Treora I would be fine to drop the RAT steps. It feels strange to download a jar and leave it on the machine. Unless we download it to the current directory. |
As for the error, something must be wrong with the permissions on the git directory that gets created. I am thinking that initializing a git repository inside the archive is a bit surprising. It definitely looks wrong to have a |
These are roughly the commands from our Creating a Release and Testing a Source Release wiki pages, with the idea to make these procedures easier for a next release.
@tilgovi & @BigBlueHat would you like to improve these scripts, or take another approach to it? Consider it just a draft; feel free to modify substantially or ignore this attempt altogether.