IGNITE-23178 : Calcite. Least restrictive type priority DOUBLE over FLOAT #11520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vladsz83
changed the title
.../org/apache/ignite/internal/processors/query/calcite/planner/NumericTypesPrecisionsTest.java
Outdated
Show resolved
Hide resolved
.../org/apache/ignite/internal/processors/query/calcite/planner/NumericTypesPrecisionsTest.java
Outdated
Show resolved
Hide resolved
.../org/apache/ignite/internal/processors/query/calcite/planner/NumericTypesPrecisionsTest.java
Outdated
Show resolved
Hide resolved
.../org/apache/ignite/internal/processors/query/calcite/planner/NumericTypesPrecisionsTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
133
to
192
| /** */ | ||
| @Test | ||
| public void testMaxPrecision() { | ||
| assertEquals(STRING_PRECISION, typeSys.getMaxPrecision(SqlTypeName.CHAR)); | ||
| assertEquals(STRING_PRECISION, typeSys.getMaxPrecision(SqlTypeName.VARCHAR)); | ||
| assertEquals(STRING_PRECISION, typeSys.getMaxPrecision(SqlTypeName.BINARY)); | ||
| assertEquals(STRING_PRECISION, typeSys.getMaxPrecision(SqlTypeName.VARBINARY)); | ||
|
|
||
| assertEquals(3, typeSys.getMaxPrecision(SqlTypeName.TINYINT)); | ||
| assertEquals(5, typeSys.getMaxPrecision(SqlTypeName.SMALLINT)); | ||
| assertEquals(10, typeSys.getMaxPrecision(SqlTypeName.INTEGER)); | ||
| assertEquals(19, typeSys.getMaxPrecision(SqlTypeName.BIGINT)); | ||
| assertEquals(7, typeSys.getMaxPrecision(SqlTypeName.REAL)); | ||
| assertEquals(15, typeSys.getMaxPrecision(SqlTypeName.FLOAT)); | ||
| assertEquals(15, typeSys.getMaxPrecision(SqlTypeName.DOUBLE)); | ||
| assertEquals(DECIMAL_PRECISION, typeSys.getMaxPrecision(SqlTypeName.DECIMAL)); | ||
|
|
||
| assertEquals(0, typeSys.getMaxPrecision(SqlTypeName.DATE)); | ||
| assertEquals(3, typeSys.getMaxPrecision(SqlTypeName.TIME)); | ||
| assertEquals(3, typeSys.getMaxPrecision(SqlTypeName.TIME_WITH_LOCAL_TIME_ZONE)); | ||
| assertEquals(3, typeSys.getMaxPrecision(SqlTypeName.TIMESTAMP)); | ||
| assertEquals(3, typeSys.getMaxPrecision(SqlTypeName.TIMESTAMP_WITH_LOCAL_TIME_ZONE)); | ||
| } | ||
|
|
||
| /** */ | ||
| @Test | ||
| public void testDefaultPrecision() { | ||
| assertEquals(1, typeSys.getDefaultPrecision(SqlTypeName.CHAR)); | ||
| assertEquals(RelDataType.PRECISION_NOT_SPECIFIED, typeSys.getDefaultPrecision(SqlTypeName.VARCHAR)); | ||
| assertEquals(1, typeSys.getDefaultPrecision(SqlTypeName.BINARY)); | ||
| assertEquals(RelDataType.PRECISION_NOT_SPECIFIED, typeSys.getDefaultPrecision(SqlTypeName.VARBINARY)); | ||
|
|
||
| assertEquals(3, typeSys.getDefaultPrecision(SqlTypeName.TINYINT)); | ||
| assertEquals(5, typeSys.getDefaultPrecision(SqlTypeName.SMALLINT)); | ||
| assertEquals(10, typeSys.getDefaultPrecision(SqlTypeName.INTEGER)); | ||
| assertEquals(19, typeSys.getDefaultPrecision(SqlTypeName.BIGINT)); | ||
| assertEquals(7, typeSys.getDefaultPrecision(SqlTypeName.REAL)); | ||
| assertEquals(15, typeSys.getDefaultPrecision(SqlTypeName.FLOAT)); | ||
| assertEquals(15, typeSys.getDefaultPrecision(SqlTypeName.DOUBLE)); | ||
| assertEquals(DECIMAL_PRECISION, typeSys.getDefaultPrecision(SqlTypeName.DECIMAL)); | ||
|
|
||
| assertEquals(0, typeSys.getDefaultPrecision(SqlTypeName.DATE)); | ||
| assertEquals(0, typeSys.getDefaultPrecision(SqlTypeName.TIME)); | ||
| assertEquals(3, typeSys.getDefaultPrecision(SqlTypeName.TIME_WITH_LOCAL_TIME_ZONE)); | ||
| assertEquals(3, typeSys.getDefaultPrecision(SqlTypeName.TIMESTAMP)); | ||
| assertEquals(0, typeSys.getDefaultPrecision(SqlTypeName.TIMESTAMP_WITH_LOCAL_TIME_ZONE)); | ||
| } | ||
|
|
||
|
|
||
| /** */ | ||
| @Test | ||
| public void testMaxNumericPrecision() { | ||
| assertEquals(DECIMAL_PRECISION, typeSys.getMaxNumericPrecision()); | ||
| } | ||
|
|
||
| /** */ | ||
| @Test | ||
| public void testMaxNumericScale() { | ||
| assertEquals(DECIMAL_SCALE, typeSys.getMaxNumericScale()); | ||
| } |
There was a problem hiding this comment.
Why do we need these tests? Values for max/default prcision are hardcoded in calcite and looks like we just compare one hardcoded value with another one.
There was a problem hiding this comment.
We manually implement several values. Like:
@Override public int getMaxNumericScale() {
return Short.MAX_VALUE;
}
/** {@inheritDoc} */
@Override public int getMaxNumericPrecision() {
return Short.MAX_VALUE;
}
or
@Override public int getDefaultPrecision(SqlTypeName typeName) {
// Timestamps internally stored as millis, precision more than 3 is redundant. At the same time,
// default Calcite precision 0 causes truncation when converting to TIMESTAMP without specifying precision.
if (typeName == SqlTypeName.TIMESTAMP || typeName == SqlTypeName.TIME_WITH_LOCAL_TIME_ZONE)
return 3;
return super.getDefaultPrecision(typeName);
}
It looks usefult to be sure that nothing would change. Or we can remove the tests. WDYT?
.../org/apache/ignite/internal/processors/query/calcite/planner/NumericTypesPrecisionsTest.java
Outdated
Show resolved
Hide resolved
alex-plekhanov
approved these changes
Sep 23, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.