Core: lazy init workerPool #12427
Open
Core: lazy init workerPool #12427
+13
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Laci, |
the actual use-case was HIVE-28759, where I'm about to supply an executorService to SnapshotProducer to be able to submit some jobs during HS2 shutdown even though the API supports scanManifestsWith, I wasn't able to achive my goal, because the static final variable was initialized in when the class is first loaded and used, see: ...so this is an edge-case, when:
I got an exception like: even this is just an edge-case, the lazy init might look better in general |
|
I have seen a similar issue here: #12220 |
|
So let me recap:
|
thanks, it looks like the very same problem, so by using the default worker pool, we need to accept the default "exiting" behavior, which is fine, as long as users can use their own pools instead, that's what's 99% satisfied by scanManifestsWith interface in my case |
exactly! |
pvary
reviewed
Feb 28, 2025
Comment on lines
200
to
+201
| protected ExecutorService workerPool() { | ||
| return this.workerPool; | ||
| return Optional.ofNullable(workerPool).orElseGet(ThreadPools::getWorkerPool); |
There was a problem hiding this comment.
I have checked the code, and there are some places where the workerPool is accessed directly.
Is this a fancy way of telling:
if (workerPool == null) {
this.workerPool = ThreadPools.getWorkerPool();
}
return workerPool;
There was a problem hiding this comment.
yeah, I think it's a cool one-liner, assuming that repeatedly calling ThreadPools::getWorkerPool is not expensive, which is true because it just returns the pool from the 2nd call:
public static ExecutorService getWorkerPool() {
return WORKER_POOL;
}
There was a problem hiding this comment.
btw, looks like I forgot to replace with workerPool(), let me do quickly
FIXED in e50b767
deniskuzZ
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For code paths where an ExecutorService can be provided, the default call to ThreadPools.getWorkerPool() can be deferred until the point of actual usage.