Skip to content

ci(python): verify wheel abi3 compatibility with --no-build #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CTTY merged 3 commits into from
Apr 29, 2026
Merged

ci(python): verify wheel abi3 compatibility with --no-build #2388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8a78dc
use --no-build
kevinjqliu Apr 29, 2026
498e5c5
fix python version
kevinjqliu Apr 29, 2026
1c05c4a
skip cross-compiled targets
kevinjqliu Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/bindings_python_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ jobs:
working-directory: "bindings/python"
shell: bash
run: |
uv pip install --reinstall dist/pyiceberg_core-*.whl
uv pip install --no-build --reinstall --find-links dist/ pyiceberg-core
- name: Run tests
working-directory: "bindings/python"
shell: bash
Expand Down
13 changes: 13 additions & 0 deletions .github/workflows/release_python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,19 @@ jobs:
working-directory: "bindings/python"
command: build
args: --release -o dist -i python3.12 # Explicitly set interpreter; manylinux containers have multiple Pythons and maturin may pick an older one
- uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
with:
version: "0.9.3"
enable-cache: true
# Verify the wheel is abi3-compatible and installable without building from source.
# Skipped for cross-compiled targets since they share the same maturin config;
# if abi3 is broken, the native target build will catch it.
- name: Verify wheel installs with no build fallback
if: matrix.target != 'aarch64' && matrix.target != 'armv7l'
working-directory: "bindings/python"
shell: bash
run: |
uv pip install --no-build --reinstall --system --find-links dist/ pyiceberg-core
- name: Upload wheels
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/release_python_nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,20 @@ jobs:
command: build
args: --release -o dist -i python3.12 # Explicitly set interpreter; manylinux containers have multiple Pythons and maturin may pick an older one

- uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
with:
version: "0.9.3"
enable-cache: true
# Verify the wheel is abi3-compatible and installable without building from source.
# Skipped for cross-compiled targets since they share the same maturin config;
# if abi3 is broken, the native target build will catch it.
- name: Verify wheel installs with no build fallback
if: matrix.target != 'aarch64' && matrix.target != 'armv7l'
working-directory: "bindings/python"
shell: bash
run: |
uv pip install --no-build --reinstall --system --find-links dist/ pyiceberg-core

- name: Upload wheels
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
Expand Down
Loading