feat(spec): add table_properties() method to TableMetadata #2002
+132
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xbattlax
force-pushed
the
use-table-properties-in-metadata
branch
from
fd29c45 to
2663a57
Compare
pratik0316
reviewed
Jan 6, 2026
pratik0316
reviewed
Jan 6, 2026
pratik0316
reviewed
Jan 6, 2026
xbattlax
force-pushed
the
use-table-properties-in-metadata
branch
4 times, most recently
from
d850c4c to
9ff17c7
Compare
liurenjie1024
approved these changes
Jan 9, 2026
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @xbattlax for this pr, LGTM! The whole pr looks much better now!
Contributor
|
Oops, we need to resolve conflicts first. |
xbattlax
force-pushed
the
use-table-properties-in-metadata
branch
from
a05b358 to
8a04a14
Compare
Add a type-safe accessor method to TableMetadata that returns TableProperties, eliminating manual TryFrom conversions at call sites. - Add table_properties() method to TableMetadata - Update transaction module to use new method - Simplify datafusion write module property access - Add tests for the new accessor method Closes apache#1878
xbattlax
force-pushed
the
use-table-properties-in-metadata
branch
from
8a04a14 to
d354055
Compare
Author
done, I fix it :) we can merge, I think that I don't have the access right to do ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a type-safe accessor method
table_properties()toTableMetadatathat returnsTableProperties, eliminating manualTryFromconversions at call sites.Changes
table_properties()method toTableMetadatathat parses and returns typedTablePropertiestransaction/mod.rsto use the new methoddatafusion/write.rsproperty access (~60 lines reduced to ~10)Closes #1878