-
Notifications
You must be signed in to change notification settings - Fork 381
chore: update denpendencies, fix ci #1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,5 +16,5 @@ | |
| # under the License. | ||
|
|
||
| [toolchain] | ||
| channel = "nightly-2024-06-10" | ||
| channel = "nightly-2024-10-17" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe those changes are not related.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I understand, but there is a python binding ci job which should check clippy, so either we upgrade the toolchain version or ignore clippy check for datafusion integration |
||
| components = ["rustfmt", "clippy"] | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, it's better to avoid updating unrelated crates' versions unless we need to use their new APIs.
Our
Cargo.tomlmaintains the minimal version we are using.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to do cargo generate-lockfile with checking minimal version, so either upgrade the tokio version or remove minimal version check.