feat: Add SnapshotSummaries
#1085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZENOTME
reviewed
Mar 19, 2025
| } | ||
|
|
||
| #[allow(dead_code)] | ||
| impl SnapshotSummaryCollector { |
There was a problem hiding this comment.
Looks like we should provide function like set(string,string) to let user set custom properities
https://github.com/apache/iceberg/blob/4dbcdfc85a64dc1d97d7434e353c7f9e4c18e1b3/core/src/main/java/org/apache/iceberg/SnapshotSummary.java#L152
There was a problem hiding this comment.
Should be fixed, this pr mostly includes the previous implementation from @barronw. I can create a follow up pr for merging summaries, duplicate deletes, manifest handling.
There was a problem hiding this comment.
Thanks @jonathanc-n for this nice pr, generally LGTM! Just some minor comments.
|
@liurenjie1024 Done! thank you for your reivew |
liurenjie1024
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This is the building block to implementing snapshot summaries. Most of the implementation code is built off of @barronw 's very nice commit. Most of the added lines are also just tests. A follow up pr will be included integrating it with the rest of the codebase.
Are these changes tested?
Yes, unit test