Skip to content

Conversation

@Fokko
Copy link
Contributor

@Fokko Fokko commented Dec 22, 2025

Closes #2849

Rationale for this change

A later version of PyParsing has a method deprecated:

ImportError while loading conftest '/home/runner/work/iceberg-python/iceberg-python/tests/conftest.py'.
tests/conftest.py:49: in <module>
    from pyiceberg.catalog import Catalog, load_catalog
pyiceberg/catalog/__init__.py:45: in <module>
    from pyiceberg.serializers import ToOutputFile
pyiceberg/serializers.py:25: in <module>
    from pyiceberg.table.metadata import TableMetadata, TableMetadataUtil
pyiceberg/table/__init__.py:38: in <module>
    import pyiceberg.expressions.parser as parser
pyiceberg/expressions/parser.py:72: in <module>
    ParserElement.enablePackrat()
.venv/lib/python3.10/site-packages/pyparsing/util.py:445: in _inner
    warnings.warn(
E   DeprecationWarning: 'enablePackrat' deprecated - use 'enable_packrat'
make: *** [Makefile:96: test] Error 4

Are these changes tested?

Are there any user-facing changes?

@kevinjqliu
Copy link
Contributor

This is upgrading pyarrow from 21 -> 22, causing CI to fail.

test_merge_manifests_file_content fails when using a different pyarrow version. likely due to the file size difference on write

@kevinjqliu
Copy link
Contributor

could you try only upgrading pyparsing?

uv lock --upgrade pyparsing

@Fokko
Copy link
Contributor Author

Fokko commented Dec 22, 2025

uv lock --upgrade pyparsing
error: unexpected argument 'pyparsing' found

Usage: uv lock [OPTIONS]

For more information, try '--help'.

I had to look this one up as well:

uv lock --upgrade-package pyparsing
Resolved 223 packages in 724ms
Updated pyparsing v3.2.5 -> v3.3.0

@Fokko Fokko requested a review from kevinjqliu December 22, 2025 18:01
@kevinjqliu kevinjqliu merged commit b43689a into apache:main Dec 22, 2025
8 checks passed
@Fokko Fokko deleted the pyparsing branch December 22, 2025 18:09
@Fokko
Copy link
Contributor Author

Fokko commented Dec 22, 2025

Thanks @kevinjqliu 🙌 I've also pushed a fix for PyArrow: #2811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ParserElement.enablePackrat deprecation warning

2 participants