Skip to content

Feat cache residual evaluator #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ForeverAngry wants to merge 3 commits into
base: main
Choose a base branch
from
+19 −0
Open

Feat cache residual evaluator #2695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bccb5c
refactor(expressions): replace custom residual evaluator LRU with cac…
ForeverAngry Dec 27, 2025
cd25393
fix(expressions): return fresh residual evaluator instances
ForeverAngry Dec 28, 2025
248b78a
refactor(expressions): remove residual evaluator caching
ForeverAngry Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pyiceberg/expressions/visitors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1973,6 +1973,12 @@ def residual_for(self, partition_data: Record) -> BooleanExpression:
def residual_evaluator_of(
spec: PartitionSpec, expr: BooleanExpression, case_sensitive: bool, schema: Schema
) -> ResidualEvaluator:
"""Create a residual evaluator.

Returns a fresh evaluator instance because evaluators are stateful
(they set `self.struct` during evaluation) and may be used from multiple
threads.
"""
return (
UnpartitionedResidualEvaluator(schema=schema, expr=expr)
if spec.is_unpartitioned()
Expand Down
13 changes: 13 additions & 0 deletions tests/expressions/test_residual_evaluator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,19 @@ def test_identity_transform_residual() -> None:
assert residual == AlwaysFalse()


def test_residual_evaluator_of_returns_fresh_instance() -> None:
Copy link
Contributor

@Fokko Fokko Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test 👍

schema = Schema(NestedField(50, "dateint", IntegerType()), NestedField(51, "hour", IntegerType()))
spec = PartitionSpec(PartitionField(50, 1050, IdentityTransform(), "dateint_part"))
predicate = LessThan("dateint", 20170815)

res_eval_1 = residual_evaluator_of(spec=spec, expr=predicate, case_sensitive=True, schema=schema)
res_eval_2 = residual_evaluator_of(spec=spec, expr=predicate, case_sensitive=True, schema=schema)

assert res_eval_1 is not res_eval_2
assert res_eval_1.residual_for(Record(20170814)) == AlwaysTrue()
assert res_eval_2.residual_for(Record(20170816)) == AlwaysFalse()


def test_case_insensitive_identity_transform_residuals() -> None:
schema = Schema(NestedField(50, "dateint", IntegerType()), NestedField(51, "hour", IntegerType()))

Expand Down