Skip to content

Conversation

@sa1
Copy link

@sa1 sa1 commented Oct 23, 2025

Rationale for this change

Closes #2530, closes #1372

Are these changes tested?

Yes

Are there any user-facing changes?

No

sa1 and others added 2 commits October 21, 2025 13:33
- Add Python 3.13 to Github Actions workflow matrices
- Update CIBW_PROJECT_REQUIRES
- Add classifier to pyproject.toml
- Update ray dependency with python 3.13 constraint
- Fix InMemoryCatalog to close connections
- Add pytest filter to ignore rest of 3.13 SQLite Resource Warnings
duckdb = { version = ">=0.5.0,<2.0.0", optional = true }
ray = { version = ">=2.10.0,<=2.44.0", optional = true }
ray = [
{ version = ">=2.10.0,<3.0.0", python = ">=3.10", optional = true },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to have a wider upper bound of 3.0.0 like this, and the tight upper bound was added as part of: #2071 (comment).

I was wondering if you were about to have a single entry since on a clean dep resolve Poetry usually chooses the highest compatible version which should technically work across all python releases.

ray = [
  { version = ">=2.45.0,<=2.49.0", python = ">=3.10", optional = true }
]

filterwarnings = [
"error",
# Python 3.13 sqlite3 module ResourceWarnings for unclosed database connections
"ignore:unclosed database in <sqlite3.Connection object*:ResourceWarning",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you seeing this with Make test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix warnings when running with Python ≥3.13 Add Python 3.13 to the test matrix

2 participants