fix: add metadata_properties to _construct_parameters when updating glue table #2097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
approved these changes
Jul 3, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
This makes sense, thanks @summermousa-vendia for working on this 👍
amitgilad3
pushed a commit
to amitgilad3/iceberg-python
that referenced
this pull request
Jul 7, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
See apache#2013
Closes apache#2064
Continuing the trend, but with glue.
# Are these changes tested?
See test below
# Are there any user-facing changes?
When a user specifies property update on commit table, those parameters
will be passed to the glue client.
<!-- In the case of user-facing changes, please add the changelog label.
-->
summermousa-vendia
deleted the
fix/glue-client-does-not-update-table-properties
branch
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
See apache#2013
Closes apache#2064
Continuing the trend, but with glue.
# Are these changes tested?
See test below
# Are there any user-facing changes?
When a user specifies property update on commit table, those parameters
will be passed to the glue client.
<!-- In the case of user-facing changes, please add the changelog label.
-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #2013
Closes #2064
Continuing the trend, but with glue.
Are these changes tested?
See test below
Are there any user-facing changes?
When a user specifies property update on commit table, those parameters will be passed to the glue client.